Skip to content

refactor: move expectations on Uri to aweXpect.Web#784

Merged
vbreuss merged 1 commit intomainfrom
topic/move-uri-to-web
Sep 14, 2025
Merged

refactor: move expectations on Uri to aweXpect.Web#784
vbreuss merged 1 commit intomainfrom
topic/move-uri-to-web

Conversation

@vbreuss
Copy link
Copy Markdown
Member

@vbreuss vbreuss commented Sep 14, 2025 •
edited
Loading

This PR moves URI-related expectations from the main aweXpect library (added in #782) to the aweXpect.Web package to better organize functionality by domain.

Key changes

  • Removes all Uri expectation methods and tests from the core aweXpect package
  • Updates API compatibility tests to reflect the removal of ThatUri class
  • Cleans up test structure by removing the entire Uris directory

@vbreuss vbreuss self-assigned this Sep 14, 2025
@vbreuss vbreuss added the refactor A change or improvement without functional impact label Sep 14, 2025
Copilot AI review requested due to automatic review settings September 14, 2025 07:57
Copilot AI reviewed Sep 14, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves URI-related expectations from the main aweXpect library to the aweXpect.Web package to better organize functionality by domain.

  • Removes all Uri expectation methods and tests from the core aweXpect package
  • Updates API compatibility tests to reflect the removal of ThatUri class
  • Cleans up test structure by removing the entire Uris directory

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

File Description
Source/aweXpect/That/Uris/*.cs Removes all Uri expectation source files including the main ThatUri class and specific method implementations
Tests/aweXpect.Tests/Uris/*.cs Removes all Uri-related test files including the main test class and individual method test suites
Tests/aweXpect.Api.Tests/Expected/*.txt Updates API compatibility baselines to reflect removal of ThatUri class and all its methods

@vbreuss
Copy link
Copy Markdown
Member Author

vbreuss commented Sep 14, 2025

Uri expectations are added to aweXpect.Web in Testably/aweXpect.Web#89!

@vbreuss vbreuss force-pushed the topic/move-uri-to-web branch from ba54983 to 419abf6 Compare September 14, 2025 07:59
@vbreuss vbreuss enabled auto-merge (squash) September 14, 2025 08:00
@vbreuss vbreuss disabled auto-merge September 14, 2025 08:00
@vbreuss vbreuss enabled auto-merge (squash) September 14, 2025 08:00
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss disabled auto-merge September 14, 2025 08:06
@vbreuss vbreuss merged commit 904d8ac into main Sep 14, 2025
11 checks passed
@vbreuss vbreuss deleted the topic/move-uri-to-web branch September 14, 2025 08:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 14, 2025 •
edited
Loading

🚀 Benchmark Results

Details 
BenchmarkDotNet v0.14.0, Ubuntu 24.04.3 LTS (Noble Numbat)

AMD EPYC 7763, 1 CPU, 4 logical and 2 physical cores

.NET SDK 8.0.414

[Host] : .NET 8.0.20 (8.0.2025.41914), X64 RyuJIT AVX2


Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10
Method Mean Error StdDev Gen0 Gen1 Allocated
Bool_aweXpect 240.9 ns 3.82 ns 3.39 ns 0.0300 - 504 B
Bool_FluentAssertions 258.2 ns 4.19 ns 3.72 ns 0.0567 - 952 B
Bool_TUnit 953.7 ns 17.43 ns 16.30 ns 0.1431 - 2408 B
Equivalency_aweXpect 316,416.7 ns 2,180.51 ns 2,039.65 ns 20.0195 0.9766 335556 B
Equivalency_FluentAssertions 2,338,220.5 ns 27,064.17 ns 23,991.68 ns 273.4375 46.8750 4584416 B
Equivalency_TUnit 708,874.6 ns 5,421.66 ns 5,071.42 ns 51.7578 2.9297 880545 B
Int_GreaterThan_aweXpect 275.3 ns 3.58 ns 3.18 ns 0.0486 - 816 B
Int_GreaterThan_FluentAssertions 259.4 ns 4.12 ns 3.44 ns 0.0730 - 1224 B
Int_GreaterThan_TUnit 1,327.3 ns 18.85 ns 17.64 ns 0.1774 - 2984 B
ItemsCount_AtLeast_aweXpect 502.0 ns 3.17 ns 2.97 ns 0.0868 - 1464 B
ItemsCount_AtLeast_FluentAssertions 511.7 ns 8.68 ns 7.69 ns 0.1192 - 2008 B
ItemsCount_AtLeast_TUnit 15,205.5 ns 84.31 ns 78.87 ns 1.6174 - 27480 B
String_aweXpect 430.8 ns 9.42 ns 8.81 ns 0.0734 - 1232 B
String_FluentAssertions 512.3 ns 6.81 ns 5.69 ns 0.1287 - 2168 B
String_TUnit 1,350.5 ns 7.55 ns 6.69 ns 0.1831 - 3072 B
StringArray_aweXpect 1,870.4 ns 11.86 ns 11.09 ns 0.1717 - 2888 B
StringArray_FluentAssertions 1,361.3 ns 25.59 ns 23.94 ns 0.2480 - 4152 B
StringArray_TUnit 3,462.6 ns 33.40 ns 31.24 ns 0.3128 - 5296 B
StringArrayInAnyOrder_aweXpect 2,339.9 ns 7.53 ns 7.05 ns 0.1831 - 3080 B
StringArrayInAnyOrder_FluentAssertions 157,162.7 ns 801.83 ns 669.56 ns 3.4180 - 63788 B
StringArrayInAnyOrder_TUnit 4,240.4 ns 19.50 ns 16.28 ns 0.3815 - 6488 B

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 14, 2025

👽 Mutation Results

Mutation testing badge

aweXpect

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

aweXpect.Core

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

github-actions Bot added a commit that referenced this pull request Sep 14, 2025
@github-actions
Update benchmark for 904d8ac: refactor: move expectations on Uri to…
5119822 
… `aweXpect.Web` (#784) by Valentin Breuß
github-actions Bot added a commit that referenced this pull request Sep 14, 2025
@github-actions
Update benchmark for 904d8ac: refactor: move expectations on Uri to…
29c9a8f 
… `aweXpect.Web` (#784) by Valentin Breuß
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 14, 2025

This is addressed in release v2.24.0.

@github-actions github-actions Bot added the state: released The issue is released label Sep 14, 2025
This was referenced Sep 15, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Sep 22, 2025
Closed
This was referenced Sep 29, 2025
Closed
Closed
Merged
This was referenced Sep 29, 2025
Closed
Closed
This was referenced Oct 7, 2025
Closed
Closed
Merged
Merged
@dependabot dependabot Bot mentioned this pull request Oct 27, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Feb 9, 2026
Closed
This was referenced Mar 30, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@vbreuss vbreuss

Labels

refactor A change or improvement without functional impact state: released The issue is released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss